Respect max-substitution-jobs again #11402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke in NixOS#11005. Any number of PathSubstitutionGoals would be woken up by a single build slot becoming available. If there are a lot of substitution goals active, this could lead to us running out of file descriptors (especially on macOS where the default limit is 256).
Slight cleanup.
edolstra
added
backport 2.24-maintenance
kh3rld
approved these changes
Sep 2, 2024
|
CC @L-as |
edolstra
added a commit
that referenced
this pull request
Sep 3, 2024
…1402 Respect max-substitution-jobs again (backport #11402)
|
Thanks! Sorry for not noticing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This broke in #11005. Any number of
PathSubstitutionGoalswould be woken up by a single build slot becoming available. If there are a lot of substitution goals active, this could lead to us running out of file descriptors (especially on macOS where the default limit is 256).Note: we have a bit of a thundering herd problem here, since it's pretty inefficient to wake up potentially hundreds of goals, most of which will immediately go to sleep again. Ideally
waitForBuildSlot()would wake up only one co-routine of the right type.Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.